Skip to content

chore(deps): update reqwest to 0.12 #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 17, 2025
Merged

chore(deps): update reqwest to 0.12 #118

merged 1 commit into from
Mar 17, 2025

Conversation

@phlip9
Copy link
Contributor

@phlip9 phlip9 commented Mar 11, 2025

Updating to LDK 0.1, I noticed esplora-client is the last dep we have using reqwest-v0.11, which forces us to hold on to a ton of duplicate, old deps in our tree (http 0.2, hyper 0.14, rustls 0.21, ...). Updating reqwest to 0.12 removes all these for us.

I've also updated the 1.63.0 MSRV instructions to pin reqwest-v0.12.9, the last version with that MSRV. Later reqwest versions bump the MSRV to 1.64.0.

@coveralls
Copy link

coveralls commented Mar 12, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 13823581735

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 88.167%
Totals Coverage Status
Change from base Build 13552496536: 0.0%
Covered Lines: 1140
Relevant Lines: 1293
💛 - Coveralls

@phlip9 phlip9 force-pushed the phlip9/update-reqwest-0.12 branch from 7ce1e08 to e624151 Compare March 12, 2025 02:39
@phlip9
Copy link
Contributor Author

phlip9 commented Mar 12, 2025 •
edited
Loading

Update: tokio-util and indexmap are no longer in the dependency tree, so remove those from the MSRV pinning

@phlip9 phlip9 force-pushed the phlip9/update-reqwest-0.12 branch from e624151 to 2b0cd90 Compare March 12, 2025 21:26
@phlip9
Copy link
Contributor Author

phlip9 commented Mar 12, 2025

Finally buckled down and got everything building w/ 1.63 locally.

  • Needed to pin reqwest to v0.12.4 to avoid all the new h3 deps.
  • The new minreq version that released yesterday also silently started break on 1.63, so pin that to v2.13.2.
  • New once_cell release also breaks MSRV, so pin to v1.20.3.
  • Pin ring to v0.17.12.

@ValuedMammal
Copy link
Contributor

@phlip9 Thanks for looking into it, I'll try to get things working on my end as well

@phlip9
Copy link
Contributor Author

phlip9 commented Mar 12, 2025

Ahh looks like some dev-dependencies also need to be pinned...

@phlip9 phlip9 force-pushed the phlip9/update-reqwest-0.12 branch from 2b0cd90 to d84d8d0 Compare March 12, 2025 23:33
@phlip9
Copy link
Contributor Author

phlip9 commented Mar 12, 2025

Pinned base64-ct to v1.6.0 and bzip2-sys to v0.1.12+1.0.8, but only in CI since these are transitive dev-dependencies.

ValuedMammal
ValuedMammal approved these changes Mar 14, 2025
View reviewed changes
Copy link
Contributor

@ValuedMammal ValuedMammal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK d84d8d0

@ValuedMammal ValuedMammal merged commit e802597 into bitcoindevkit:master Mar 17, 2025
25 checks passed
@phlip9 phlip9 deleted the phlip9/update-reqwest-0.12 branch March 18, 2025 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ValuedMammal ValuedMammal ValuedMammal approved these changes

@oleonardolima oleonardolima Awaiting requested review from oleonardolima

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@phlip9 @coveralls @ValuedMammal